UCT/TCP: Fix PUT protocol

[dmitrygx]

What

Fix PUT protocol

Why ?

The following happens on UCP when TCP and MM are used (TCP for PUT, MM for AM):

• MM sends RTS from sender
• MM sends RTR from receiver
• TCP does PUT and completes it in-place, but some data still is sending by TCP/IP stack
• MM sends ATP immediately from sender
• Receiver verifies the data, it is incomplete

How ?

1. Always return UCS_INPROGRESS from TCP PUT operation and add user's completion to a queue of PUT completions that are waiting for ACK.
2. Allocate PUT completion from iface TX mpool instead of heap by doing calloc().
3. Update UCP TAG match RNDV tests to run over TCP/MM, it reproduces the bug.

[dmitrygx]

@yosefe this PR based on your patch for TCP with some changes related to PUT return value (it is always UCS_INPROGRESS now) and using mpool elements fotr PUT completions instead of allocation from heap

[dmitrygx]

@brminich @hoopoepg could you review pls?
the io_demo failure is unrelated

[yosefe]

extra space

[dmitrygx]

fixed

[yosefe]

👍
did u manage to repro the issue with this?

[dmitrygx]

👍
did u manage to repro the issue with this?

yes, the tests check the data consistency, and those tests are failed

[dmitrygx]

[ RUN      ] mm_tcp/test_ucp_tag_match_rndv.sync_send_unexp/0 <posix,sysv,tcp/rndv_auto>
ucp/test_ucp_tag_match.cc:521: Failure
Value of: recvbuf
  Actual: { '\x8A' (138), '\xAC' (172), '\x80' (128), 'd' (100, 0x64), '\0', '\0', '\0', '\0', 'u' (117, 0x75), '\xBD' (189), '\x6' (6), '\xED' (237), '\x3' (3), '\0', '\0', '\0', '\xA3' (163), 'f' (102, 0x66), 'C' (67, 0x43), 'B' (66, 0x42), '\'' (39, 0x27), '\0', '\0', '\0', 'o' (111, 0x6F), '\x2' (2), '\xA2' (162), '\x96' (150), '\x88' (136), '\x1' (1), '\0', '\0', ... }
Expected: sendbuf
Which is: { '\x8A' (138), '\xAC' (172), '\x80' (128), 'd' (100, 0x64), '\0', '\0', '\0', '\0', 'u' (117, 0x75), '\xBD' (189), '\x6' (6), '\xED' (237), '\x3' (3), '\0', '\0', '\0', '\xA3' (163), 'f' (102, 0x66), 'C' (67, 0x43), 'B' (66, 0x42), '\'' (39, 0x27), '\0', '\0', '\0', 'o' (111, 0x6F), '\x2' (2), '\xA2' (162), '\x96' (150), '\x88' (136), '\x1' (1), '\0', '\0', ... }

[dmitrygx]

#5938 failure

[dmitrygx]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dmitrygx]

bot:pipe:retest

[dmitrygx]

@yosefe ok to merge?