Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCS/DEBUG: handle error return from ucs_debug_backtrace_create() #8741

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

bfaccini
Copy link
Contributor

@bfaccini bfaccini commented Dec 3, 2022

This will avoid to crash during signal-handling/stack-unwinding upon ENOMEM/failed memory alloc situation.

Signed-off-by: Bruno Faccini bruno.faccini@intel.com

What

Add error handling in order to avoid crashes.

Why ?

For UCX Issue #8716 .

How ?

It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.

This will avoid to crash during signal-handling/stack-unwinding
upon ENOMEM/failed memory alloc situation.

Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
@shamisp
Copy link
Contributor

shamisp commented Dec 3, 2022

@bfaccini , thanks for the patch! In order to accept the contribution we need singed CLA, which can be found here:
https://openucx.org/license/ and emailed to admin at ucfconsortium.org.

@bfaccini
Copy link
Contributor Author

bfaccini commented Dec 4, 2022

@bfaccini , thanks for the patch! In order to accept the contribution we need singed CLA, which can be found here:
https://openucx.org/license/ and emailed to admin at ucfconsortium.org.

@shamisp I have sent it on Nov 24th, and got replies that my UCF Consortium account has been approved. But may be this is not enough ?

@shamisp
Copy link
Contributor

shamisp commented Dec 4, 2022

@bfaccini , thanks for letting me know, I'm checking

@shamisp
Copy link
Contributor

shamisp commented Dec 7, 2022

@yosefe the CLA was countersigned

@yosefe yosefe merged commit f73bab5 into openucx:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants