-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA: make cuGetProcAddress to work with cuda 12 #8763
Conversation
@Akshay-Venkatesh can you please take a look ? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shamisp changes look fine but we probably ought to consolidate code which gets split based on version. There are other instances similar to these where fxn signature changes but we should probably have a common function so that caller doesn't see all the ugly bits.
@Akshay-Venkatesh In a longer term this makes sense but it is much more substantial overhaul of CUDA UCT. Majority of the ifdef flows were introduced in 11070 and I didn't want to change this. |
Agreed that we should not make that overhaul in this PR. Minor nitpick: the title of this PR is deceiving. Shouldn't it just be "make cuGetProcAddress work with cuda 12"? |
agreed |
e71f368
to
c812f05
Compare
@Akshay-Venkatesh can you please approve so I can merge it once it is ready ? thanks ! |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@shamisp can you pls squash? |
c812f05
to
f572bb7
Compare
@yosefe DONE. The failures are unrelated: |
What
CUDA: Adding support for CUDA-12