Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS/PERF/TEST: Fix build without openmp #9850

Merged

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Apr 28, 2024

Why

Fixes #9848

buildlib/tools/builds.sh Outdated Show resolved Hide resolved
src/tools/perf/lib/libperf.c Outdated Show resolved Hide resolved
tvegas1
tvegas1 previously approved these changes Apr 30, 2024
@yosefe
Copy link
Contributor Author

yosefe commented Apr 30, 2024

@tvegas1 can you pls review again?

tvegas1
tvegas1 previously approved these changes Apr 30, 2024
Copy link
Contributor

@tvegas1 tvegas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetic comment since dir exists in practice

buildlib/tools/builds.sh Outdated Show resolved Hide resolved
@yosefe yosefe force-pushed the topic/tools-perf-test-fix-build-without-openmp branch from bfc8d53 to bcac522 Compare May 1, 2024 06:52
@yosefe yosefe merged commit 5616643 into openucx:master May 1, 2024
140 checks passed
@yosefe yosefe deleted the topic/tools-perf-test-fix-build-without-openmp branch May 1, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenMP required by libperf.c's ucx_perf_do_warmup
2 participants