Skip to content

Conversation

jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Sep 29, 2025

For guest programs with MSRV 1.87+, it is convenient for cargo openvm build to use a newer Rust toolchain. We chose 2025-08-02 since that is when the last stable Rust 1.90.0 branched from master: https://releases.rs/docs/1.90.0/

Note that users can always override the toolchain version with env var OPENVM_RUST_TOOLCHAIN.

workflow run: https://github.com/axiom-crypto/openvm-reth-benchmark/actions/runs/18085897389/job/51456939479

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the default nightly Rust toolchain version used by cargo openvm build from nightly-2025-02-14 to nightly-2025-08-01 to better support guest programs with MSRV 1.87+.

  • Update default Rust nightly toolchain to nightly-2025-08-01
  • Document the toolchain change in the changelog

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/toolchain/build/src/lib.rs Updates the DEFAULT_RUSTUP_TOOLCHAIN_NAME constant to use the newer nightly version
CHANGELOG.md Adds entry documenting the toolchain version update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This comment has been minimized.

For guest programs with MSRV 1.87+, it is convenient for `cargo openvm
build` to use a newer Rust toolchain. We chose `2025-08-02` since that
is when the last stable Rust 1.90.0 branched from master: https://releases.rs/docs/1.90.0/

Note that users can always override the toolchain version with env var
`OPENVM_RUST_TOOLCHAIN`.
@jonathanpwang jonathanpwang force-pushed the chore/bump-openvm-rust-nightly branch from 8ab479c to 434ad0d Compare September 29, 2025 04:34
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-32 [-12.5%]) 225 322,610 2,058,654 - - -
fibonacci (+37 [+3.8%]) 1,023 1,500,209 (-7560 [-0.4%]) 2,100,402 - - -
regex (+13 [+0.6%]) 2,352 (+28022 [+0.7%]) 4,137,372 (+40192 [+0.2%]) 17,759,394 - - -
ecrecover (-6 [-0.9%]) 697 (-14273 [-10.4%]) 122,859 (-14284 [-0.6%]) 2,263,820 - - -
pairing (+38 [+2.7%]) 1,438 (-137197 [-7.3%]) 1,745,742 (-376960 [-1.5%]) 25,468,210 - - -

Commit: 434ad0d

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 13362dc into main Sep 29, 2025
40 checks passed
@jonathanpwang jonathanpwang deleted the chore/bump-openvm-rust-nightly branch September 29, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants