Skip to content

Fix JS custom tests #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

Fix JS custom tests #2757

merged 1 commit into from
Sep 25, 2025

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Sep 25, 2025

This breaks npm run add-new-bcd. I think the namespaces are duplicated, so removed the "javascript.functions." part.

@Elchi3 Elchi3 requested a review from queengooborg September 25, 2025 10:55
@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-2757 September 25, 2025 10:56 Inactive
queengooborg
queengooborg approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Don't know how that slipped past me, good catch!

@queengooborg queengooborg merged commit ae76db1 into main Sep 25, 2025
6 checks passed
@queengooborg queengooborg deleted the fix-js-custom-tests branch September 25, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elchi3 @queengooborg