Create a basic instructor dashboard #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
force-pushed
the
instructor-dashboard2
branch
from
15266a0 to
58d1f71
Compare
FIX: both refresh and course switching is working now.
pstaabp
force-pushed
the
instructor-dashboard2
branch
from
58d1f71 to
bbab79f
Compare
|
This is ready for review. Course switching works with no errors now. |
drdrew42
requested changes
Aug 17, 2022
drdrew42
force-pushed
the
instructor-dashboard2
branch
from
c2efb62 to
a1a2afc
Compare
drdrew42
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
I'll put in a PR for this branch -- I think I've got most of these recommendations already in.
I think we've resolved the main issues, but we definitely need to start a list of things to refactor UI-side (axios hooks, that error wrapping function that returns a Promise? etc)
pstaabp
force-pushed
the
instructor-dashboard2
branch
from
a1a2afc to
210ec63
Compare
drgrice1
approved these changes
Aug 26, 2022
drdrew42
force-pushed
the
instructor-dashboard2
branch
from
210ec63 to
79b240d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a very basic instructor dashboard (mainly with instructions to select a different tool) as well as fixes some errors when switching courses as a user.
This replaces #102. Main was rebased onto this branch so this is much clearer.