-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carry over standalone #3
Comments
TYPE: bug fix KEYWORDS: GOCART, settling SOURCE: Stacy Walters (internal) DESCRIPTION OF CHANGES: Put calculation of aerosol settling (variable = transfer_to_below_level) in layers > 1 into IF/ELSE block that calculates gravitational settling for layer = 1. LIST OF MODIFIED FILES: M chem/module_gocart_settling.F TEST CONDUCTED: Jenkins shows all tests PASS **Compiled with debug option -check bounds** _BEFORE FIX_: 2 indexes are OOB for l==1, 3rd dim of delz (> MAX) and 3rd dim of airden (0) rsl.out.0000 l/=1, calculting transfer_to_below_level = 3.153560196907218E-014 l/=1, calculting transfer_to_below_level = 1.014890436929303E-012 l/=1, calculting transfer_to_below_level = 2.118741307102124E-011 l==1, still calculating transfer_to_below_level = = (temp_tc*vd_wk1)*((delz(i,j,l2)*airden(i,j,l))/(delz(i,j,l2+1)*airden(i,j,l-1))) l==1, index of airden(i,j,l-1) = 1 1 0 and index of delz(i,j,l2+1) = 1 1 31 but size of 3rd dim of delz = 30 rsl.error.0000 forrtl: severe (408): fort: (2): Subscript #3 of the array DELZ has value 31 which is greater than the upper bound of 30 _AFTER FIX_: l/=1, calculating transfer_to_below_level = 3.153560196907218E-014 l/=1, calculating transfer_to_below_level = 1.014890436929303E-012 l/=1, calculating transfer_to_below_level = 2.118741307102124E-011 l==1, not calculating transfer_to_below_level
Need a main program to test balbi model. |
Further development merged into #45, leaving branch develop-3 as stable for now until develop-45 can be merged into master. |
Branches master, develop-45, and develop-3 advanced to the same commit d9b313e Fri Aug 26 23:44:51 2022 |
@Fergui @Aurel31
The reason seems to be that commits after my last commit 3c960d7 to the tip of develop-3 (currently at 363ce81) are changes in the fuel subsystem and conflict with different changes the fuel subsystem in the release branch (currently at 792e703). I am continuing standalone as branch develop-3jm from my last commit 3c960d7 and abandoning branch develop-3. Please review the orphaned commits in branch develop-3 after 3c960d7 and merge or cherry pick somewhere if you want to keep them. |
Hi @janmandel |
Standalone driven by wrfout OK, closing the issue #3 |
On branch develop-3-abandoned No changes
@Aurel31 |
Split standalone off from https://github.com/openwfm/wrf-fire and make it work with https://github.com/openwfm/WRF-SFIRE
The text was updated successfully, but these errors were encountered: