Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the Massman model to WRF 4.4 upgrade and Balbi model #4

Open
janmandel opened this issue May 21, 2020 · 6 comments
Open

Merge the Massman model to WRF 4.4 upgrade and Balbi model #4

janmandel opened this issue May 21, 2020 · 6 comments
Assignees
@janmandel @Fergui
Labels
needstesting Done but needs regression testing newfeature New feature or request

Comments

@janmandel
Copy link
Member

janmandel commented May 21, 2020 •
edited
Loading

In branch dvm_branch, has prereq #6 #10
@janmandel janmandel changed the title Carry over the Massman model Merge the Massman model to WRF 4.2 upgrade Jun 11, 2020
@janmandel
Copy link
Member Author

janmandel commented Jun 12, 2020 •
edited
Loading

Imported filtered/dvm_branch up to 01f3de8
Need to merge with master, resolve conflicts in registry.fire, and make ideal canopy case.

@janmandel janmandel mentioned this issue Jun 12, 2020
Closed
@janmandel
Copy link
Member Author

janmandel commented Jun 13, 2020 •
edited
Loading

Merged with develop e4d93dc
Making ideal test case at test/em_fire/canopy_wind c8d9347
Test case nonzero cuf, cvf 70444d0

@janmandel
Copy link
Member Author

master branch at 80a3806 and develop/dvm_branch at 0fdb407 give bit identical results on hill ideal test case not using Massman. Both have the #10 bug fix in.

janmandel added a commit that referenced this issue Jun 14, 2020
@janmandel
Merging dvm_branch to master. Fixes #4
cbdd81f
@janmandel janmandel mentioned this issue Sep 5, 2020
Closed
@janmandel janmandel reopened this Mar 5, 2021
@janmandel
Copy link
Member Author

Using Landfire data as requested by Adam, branch dvm updated by Derek d8e5bf1

janmandel added a commit that referenced this issue Feb 8, 2022
@janmandel
Merge branch 'dvm' into 'master', needs testing #4
767a6e3 
	modified:   Registry/Registry.EM_COMMON
	modified:   Registry/registry.fire
	modified:   phys/module_fr_sfire_atm.F
	modified:   phys/module_fr_sfire_core.F
	modified:   phys/module_fr_sfire_driver.F
	modified:   phys/module_fr_sfire_driver_wrf.F
	modified:   phys/module_fr_sfire_model.F
	modified:   phys/module_fr_sfire_util.F
	modified:   run/LANDUSE.TBL
	modified:   run/VEGPARM.TBL
@Fergui
Copy link
Member

Fergui commented Feb 14, 2022 •
edited
Loading

Massman model code in branch dvm commit 767a6e3 and current master branch commit 0a634ac were used to run ideal cases without massman parametrization in Cheyenne:

  • master hill experiment: /glade/u/home/angelfc/work/massman/WRF-SFIRE_master/test/em_fire/hill
  • dvm hill experimenrt: /glade/u/home/angelfc/work/massman/WRF-SFIRE_dvm/test/em_fire/hill
  • master rain1 experiment: /glade/u/home/angelfc/work/massman/WRF-SFIRE_master/test/em_fire/rain1
  • dvm rain1 experiment: /glade/u/home/angelfc/work/massman/WRF-SFIRE_dvm/test/em_fire/rain1

The results from both experiments were compared using ncdiff matlab tool in https://github.com/openwfm/wrf-fire-matlab repository. Resulting log file can be find in Cheyenne here: /glade/u/home/angelfc/work/massman/wrf-fire-matlab/ncdiff_massman.log
Multiple variables show significant differences including all the fire variables and some atmospheric variables like pressure, temperature, and winds.

janmandel added a commit that referenced this issue Apr 1, 2022
@janmandel
current massman code in branch dvm #4
3ba6eff
@janmandel janmandel changed the title Merge the Massman model to WRF 4.2 upgrade Merge the Massman model to WRF 4.4 upgrade Oct 16, 2022
@janmandel janmandel changed the title Merge the Massman model to WRF 4.4 upgrade Merge the Massman model to WRF 4.4 upgrade and Balbi model Oct 16, 2022
@llsalazar llsalazar mentioned this issue Jun 1, 2023
Open
@Fergui Fergui added the needstesting Done but needs regression testing label Jun 25, 2023
@Fergui Fergui self-assigned this Jun 25, 2023
@Fergui
Copy link
Member

Fergui commented Jun 25, 2023

Reconcile branches dvm and dvm_branch is needed.
Regression testing is necessary.

@Fergui Fergui added the newfeature New feature or request label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janmandel janmandel

@Fergui Fergui

Labels
needstesting Done but needs regression testing newfeature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janmandel @Fergui