fix(sessions): make user cookie persistant #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienjoly
commented
Jul 14, 2019
| @@ -144,16 +144,16 @@ function makeMongoUrl(params) { | |||
| } | |||
|
|
|||
| function start() { | |||
| var myHttp = require('./app/lib/my-http-wrapper/http'); | |||
| const myHttp = require('./app/lib/my-http-wrapper/http'); | |||
There was a problem hiding this comment.
unrelated change. #boyscoutrule
adrienjoly
changed the title
adrienjoly
pushed a commit
that referenced
this pull request
Jul 14, 2019
## [1.11.1](v1.11.0...v1.11.1) (2019-07-14) ### Bug Fixes * **sessions:** make user cookie persistant ([#209](#209)) ([bba528d](bba528d))
adrienjoly
added a commit
that referenced
this pull request
Jul 14, 2019
In #209, I re-introduced cookie expiration using express-session's maxAge property, but had defined it at the wrong path of the settings object. Now defined in cookie.maxAge instead of just maxAge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208.
What does this PR do / solve?
User needs to login again, everytime they restarts their browser. (including Openwhyd's iOS and Electron apps)
Overview of changes
Specify a
maxAgefor cookies, so that they don't become browser-session-based by default.How to test this PR?