Detect changes in node and link information #39 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloCastellano
force-pushed
the
issue/39-detect-node-changes
branch
2 times, most recently
from
e7bd461
to
cf7b086
Compare
nemesifier
requested changes
Jun 12, 2020
There was a problem hiding this comment.
I think the README needs an update regarding this, don't you think?
Especially to explain what happens when properties are removed, because that's new.
We should link this in the changelog too, so please make a section so we can link it.
I uploaded a few failing tests to guide you through fixing the problem correctly.
I realized links suffer the same problem but the title didn't indicate it, I updated this because we need to fix it as well.
PabloCastellano
force-pushed
the
issue/39-detect-node-changes
branch
from
0d8e28b
to
1afc328
Compare
PabloCastellano
changed the title
PabloCastellano
force-pushed
the
issue/39-detect-node-changes
branch
3 times, most recently
from
3f16443
to
9801a99
Compare
nemesifier
reviewed
Jun 18, 2020
There was a problem hiding this comment.
Good progress!
I've been testing it with the network-topology module and here's what I found:
openwisp/openwisp-network-topology#66 (comment)
Can you address my comments below and that other issue as well?
PabloCastellano
force-pushed
the
issue/39-detect-node-changes
branch
from
9580c2d
to
77699d9
Compare
Nodes (label, local_addresses and properties) Links (cost, cost_text, properties) Closes #39
PabloCastellano
force-pushed
the
issue/39-detect-node-changes
branch
from
77699d9
to
5ab32a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes (label, local_addresses and properties)
Links (cost, cost_text, properties)
Closes #39