[chores/docs] Remove HTTP and SSH backends #53 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves part of #53
pandafy
requested changes
May 24, 2021
docs/source/index.rst
Outdated
|
|
||
| The legacy versions of this project had support for SSH and HTTP for extracting information from | ||
| devices. To see how it worked, visit the | ||
| `0.1.0 pre-alpha release <https://github.com/openwisp/netengine/releases/tag/0.1.0a>`_ page on |
There was a problem hiding this comment.
Read the docs provides versioned documentation. If it is not much work to set it up, then we can enable that and use that link here instead.
If above is not quickly doable, then we can link https://github.com/openwisp/netengine/tree/0.1.0a instead of the tag. We can update this link later while releasing the module
There was a problem hiding this comment.
Also, it was an alpha release, not pre-alpha.
There was a problem hiding this comment.
Add a note in #56, if you want to delegate enabling versioned documentation. So we remember that we need to take care of this.
pandafy
reviewed
May 24, 2021
nemesifier
reviewed
May 24, 2021
nemesifier
requested changes
May 24, 2021
nemesifier
approved these changes
May 26, 2021
| @@ -1,6 +1,3 @@ | |||
| paramiko | |||
| pysnmp | |||
| ipaddress | |||
There was a problem hiding this comment.
once we migrate to python3 we should be able to remove this as well, let's keep in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #53