GCI Task: [netjsonconfig] TypeError: can only concatenate list (not "str") to list

[yasharora102]

This Issue is in reference to the issue #118 . It would be great to have your views on the changes made.
Thank you in advance.

Closes #118

[coveralls]

Coverage increased (+0.0002%) to 99.931% when pulling be7fb2b on stealthflame:issue118 into 3d25204 on openwisp:master.

[nemesifier]

Your test is not being triggered, see my comment below with the suggested solution.

[nemesifier]

on OpenWRT, ipaddr is for ipv4, you have to use ip6addr to trigger your test, use the following:

option ip6addr '2aa1:4aaa:2aaa:1d::5/64'

Update the expected value accordingly as well.

[yasharora102]

Thank you @nemesisdesign for the feedback. I have made the changes and updated the PR 😄

[nemesifier]

👍

[nemesifier]

Good @stealthflame, now squash the commits into one and discard the second commit message

[nemesifier]

Write a good commit message that follows our guidelines please.

[yasharora102]

Done @nemesisdesign

[nemesifier]

Commit message still doesn't adhere to our guidelines. You need to learn this.
http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines
Look at how other commits are structured and follow the same conventions.

[nemesifier]

@stealthflame you don't need to close it, just push force to your branch

[yasharora102]

Done @nemesisdesign sorry for the inconvenience. I was editing my previous commit and by mistake made reset by hard.

[nemesifier]

@stealthflame you should have mentioned and closed the issue in the commit description as per our guidelines but I'm tired to send the task back to you. We are introducing an automatic check soon and this kind of errors will be automatically rejected by our build system so I suggest you to spend a bit more time understanding how to properly format your commit messages