Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Registered menu groups #108 #109

Merged
merged 3 commits into from
Aug 1, 2021
Merged

[enhancement] Registered menu groups #108 #109

merged 3 commits into from
Aug 1, 2021

Conversation

niteshsinha17
Copy link
Member

Changes

Registered menu groups

Checklist

  • I have read the contributing guidelines.
  • I have manually tested the proposed changes.
  • I have written new test cases to avoid regressions. (if necessary)
  • I have updated the documentation. (e.g. README.rst)

closes #108

@coveralls
Copy link

coveralls commented Jun 28, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 99.397% when pulling 3ea0a33 on issues/108-register-menu-groups into ac7119d on master.

@niteshsinha17 niteshsinha17 force-pushed the issues/108-register-menu-groups branch 6 times, most recently from 55046bb to 50e72ce Compare July 24, 2021 02:46
@niteshsinha17 niteshsinha17 force-pushed the issues/108-register-menu-groups branch from 50e72ce to 8101a46 Compare July 24, 2021 02:49
nemesifier
nemesifier previously approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's wait to merge until openwisp-utils is merged

@nemesifier nemesifier merged commit e7349cb into master Aug 1, 2021
@atb00ker atb00ker deleted the issues/108-register-menu-groups branch January 21, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] Register menu groups
3 participants
@niteshsinha17 @coveralls @nemesifier