-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Added setUserData to called after logout #343 #344
Conversation
afda845
to
e398a00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase on the latest master and fix conflicts please?
e398a00
to
3b15808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codesankalp can you please indicate if there's any tests which replicates the issue and fails without the fix? If not, could you add at least one?
If the session is active then setUserData is not called after captive portal logout. Added setUserData with initialData.userData after performing captive portal logout. Fixes #343
3b15808
to
db6acb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @codesankalp, I have a few doubts, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now, @pandafy could you please double check if the error you were having is fixed?
I confirm this solves the issue I was facing. 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codesankalp could you squash the commits so we have one per issue? Thanks.
Thank you @pandafy 👏. |
Added validateToken where user can logout. Made handleLogout function reusable. Used `mustLogout=true` in handleLogout for captive portal logout. Closes #306
c35b5ed
to
802853f
Compare
If the session is active then setUserData is not called after captive
portal logout. Added setUserData with initialData.userData after
performing captive portal logout.
Fixes #343
Closes #306