luci-mod-network: add address parameter in DHCP for dnsmasq #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a |
feckert
changed the title
najdanovicivan
force-pushed
the
patch-2
branch
from
91f3609
to
057727f
Compare
|
I've lint the code and signed it off |
|
Please update your commit header |
Address is very useful in dnsmasq. I don't see a reason why we should not have it in the form Signed-off-by: Najdanovic Ivan <najdanovicivan@gmail.com>
najdanovicivan
force-pushed
the
patch-2
branch
from
057727f
to
8463929
Compare
|
I've amended the commit and added luci-mod-network: |
|
@feckert When can this be merged ? |
|
Any reason why this one is waiting so long to be merged ? |
|
Sorry, I forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address is very useful in dnsmasq. I don't see a reason why we should not have it in the form