luci-app-upnp: Fix rpc handler for nftables #5839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite great portions of the rpcd handler script to utilize the newer nftables implementation for firewall4-using versions. This is required because miniupnpd-nftables creates tables that are incompatible with iptables-nft. There may be some race conditions with deleting the lease entries, since it opens the file to locate the line number to delete. There could be a better way to do this. Signed-off-by: Christopher Snowhill <kode54@gmail.com>
|
I wonder if we would need separate luci-app-upnp-iptables and luci-app-upnp-nftables, as miniupnpd has both variants (and there are die-hard fw3 users) Any thoughts, @jow- ? |
msylgj
added a commit
to msylgj/luci-app-upnp
that referenced
this pull request
Jun 24, 2022
Thanks to @kode54 via: openwrt/luci#5839
msylgj
added a commit
to msylgj/luci-app-upnp
that referenced
this pull request
Jun 24, 2022
Thanks to @kode54 via: openwrt/luci#5839
|
Superseded by 82eec98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite great portions of the rpcd handler script to utilize the
newer nftables implementation for firewall4-using versions. This
is required because miniupnpd-nftables creates tables that are
incompatible with iptables-nft. There may be some race conditions
with deleting the lease entries, since it opens the file to
locate the line number to delete. There could be a better way to
do this.
Signed-off-by: Christopher Snowhill kode54@gmail.com