Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opkg: search all dest installed packages instead of root only #6632

Closed
wants to merge 5 commits into from
Closed

Opkg: search all dest installed packages instead of root only #6632

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2023

Search all dest in /etc/opkg.conf listed, and output all dest installed packages

Opkg: search all dest installed packages instead of root only
667129b 
Signed-off-by: CoiaPrant <112553141+CoiaPrant233@users.noreply.github.com>
@feckert
Copy link
Member

feckert commented Oct 16, 2023

Some more information would be nice why we need this?

@ghost
Copy link
Author

ghost commented Oct 16, 2023 via email

@feckert
Copy link
Member

feckert commented Oct 17, 2023

Install software to external storage without using extroot

The answer should go to the commit message and you must also add a Signed-off-by with your real name and a valid email address. Not with a mail from github users.noreply.github.com

@ghost
Copy link
Author

ghost commented Oct 19, 2023

Install software to external storage without using extroot

The answer should go to the commit message and you must also add a Signed-off-by with your real name and a valid email address. Not with a mail from github users.noreply.github.com

Install software to external storage without using extroot

@systemcrash
Copy link
Contributor

Install software to external storage without using extroot

The answer should go to the commit message and you must also add a Signed-off-by with your real name and a valid email address. Not with a mail from github users.noreply.github.com

Install software to external storage without using extroot

In the git commit message, not this PR thread :)

@systemcrash systemcrash added fix pull request fixing a bug Needs testing Need testing Work needed Needs work by the pullrequest creator labels Dec 5, 2023
@ghost
Copy link
Author

ghost commented Dec 12, 2023

Install software to external storage without using extroot

The answer should go to the commit message and you must also add a Signed-off-by with your real name and a valid email address. Not with a mail from github users.noreply.github.com

Install software to external storage without using extroot

In the git commit message, not this PR thread :)

i think merge pull request can compress commit and edit commit message

jow-
jow- reviewed Dec 12, 2023
View reviewed changes
applications/luci-app-opkg/root/usr/libexec/opkg-call
@@ -7,7 +7,12 @@ shift

case "$action" in
list-installed)
cat /usr/lib/opkg/status
dest_dirs=$(sed -rne 's#^dest \S+ (\S+)#\1#p' /etc/opkg.conf /etc/opkg/*.conf 2>/dev/null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of keyword, name and value words in opkg.conf may be double quoted (ref: https://git.openwrt.org/?p=project/opkg-lede.git;a=blob;f=libopkg/opkg_conf.c;h=0cbd1ccab73fb1c8051ffd811d8e2c40f010e969;hb=d038e5b6d155784575f62a66a8bb7e874173e92e#l212

Additionally, arbitrary amount of white space is allowed before, after and between directive words. For robustness reasons, the code should also fall back to /usr/lib/opkg/status in case destinations cannot be properly parsed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallback already added.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code modify from list-available, so if u want to impl All of keyword, name and value words in opkg.conf may be double quoted, i think u also need to modify list-available.

@systemcrash systemcrash marked this pull request as draft December 30, 2023 02:58
@ghost ghost marked this pull request as ready for review January 4, 2024 02:10
@ghost ghost closed this Jan 4, 2024
@ghost ghost deleted the patch-1 branch January 4, 2024 02:20
@ghost ghost mentioned this pull request Jan 4, 2024
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix pull request fixing a bug Needs testing Need testing Work needed Needs work by the pullrequest creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feckert @systemcrash @stokito @jow-