luci-mod-network: wireless.js: implement method to set Operating Channel Validation #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For full completeness you should run |
huaracheguarache
force-pushed
the
luci_ocv
branch
2 times, most recently
from
1cc68ad
to
3261157
Compare
|
Ok, now I've included a commit that updates the translation files. Thanks for the tip, @dannil! |
huaracheguarache
force-pushed
the
luci_ocv
branch
from
236b332
to
03023bb
Compare
huaracheguarache
force-pushed
the
luci_ocv
branch
from
03023bb
to
6b2bacf
Compare
systemcrash
reviewed
Mar 31, 2024
modules/luci-mod-network/htdocs/luci-static/resources/view/network/wireless.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/wireless.js
Show resolved
Hide resolved
huaracheguarache
force-pushed
the
luci_ocv
branch
3 times, most recently
from
e2a106d
to
38377a7
Compare
huaracheguarache
force-pushed
the
luci_ocv
branch
2 times, most recently
from
51cd534
to
6d50de0
Compare
|
@huaracheguarache could you rebase your changes please? |
Required for luci to check whether installed hostapd or wpa_supplicant is built with the Operating Channel Validation feature. Signed-off-by: Michael Yartys <mail@yartys.no>
Make it possible to set Operating Channel Validation through luci. Signed-off-by: Michael Yartys <mail@yartys.no>
Update translation files after adding option to set Operating Channel Validation. Signed-off-by: Michael Yartys <mail@yartys.no>
huaracheguarache
force-pushed
the
luci_ocv
branch
from
9ac439c
to
1a1b3a5
Compare
|
@systemcrash Ok, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting Operating Channel Validation has long been possible in the wireless config file with the
ocvparameter, and this pull request implements a method to set it in luci. It is done by adding a drop-down menu below the 802.11w settings in the wireless security tab as seen in the screenshot below:OCV can only be used in conjunction with 802.11w, so I've added a dependency check that makes sure that 802.11w is either set to optional or mandatory. The OCV setting has two enabled values, where one is a workaround mode that allows buggy clients to connect. This setting is only relevant in ap or ap-wds mode, so I've added a validator function that will warn the user if they've selected this option while in sta or sta-wds mode.
I've done some limited testing on my setup with an R7800 running in ap mode with WPA3-SAE+802.11r encryption. It's probably a good idea if more people could take this for a spin to make sure that it works properly. I've also added a commit that updates the associated translation files, as per @dannil's suggestion. I would appreciate any comments about the positioning of the drop-down menu, the text strings I've used etc.
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packages