Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-ddns: make service-specific 'cacert' optional #7172

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

bam80
Copy link
Contributor

@bam80 bam80 commented Jun 20, 2024

Seems like it should be optional as we have global 'cacert' setting above

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) βœ…
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

Seems like it should be optional as we have global 'cacert' setting above

Signed-off-by: Andrey Butirsky <butirsky@gmail.com>
@systemcrash
Copy link
Contributor

Seems OK - @Ansuel ?

@systemcrash systemcrash marked this pull request as ready for review July 22, 2024 22:42
@systemcrash systemcrash merged commit b09148a into openwrt:master Jul 22, 2024
1 check passed
@systemcrash
Copy link
Contributor

Merged. Thanks @bam80

@bam80
Copy link
Contributor Author

bam80 commented Jul 23, 2024

@systemcrash You are welcome but I didn't check this patch, hope you did it before the merge

@bam80 bam80 deleted the patch-1 branch July 23, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants