Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-base: fix regression add by button-row class #7200

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

feckert
Copy link
Member

@feckert feckert commented Jul 18, 2024

This should fix the regression that was introduced by #7153

  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • ( Preferred ) Mention: @jow-
  • Description: (describe the changes proposed in this PR)

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
…class

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
@feckert feckert marked this pull request as ready for review July 19, 2024 06:50
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
feckert referenced this pull request Jul 19, 2024
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
@feckert
Copy link
Member Author

feckert commented Jul 19, 2024

@systemcrash @dannil @zdz2019 All the problems mentioned should be solved with this PR.

@zxlhhyccc
Copy link

Problem resolved, hope to merge soon.
By the way, would it be better if these two buttons were swapped?
image

@feckert feckert merged commit b3ea37c into openwrt:master Jul 19, 2024
5 checks passed
@feckert feckert deleted the pr/20240718-luci-base branch July 19, 2024 13:34
@zdz2019
Copy link

zdz2019 commented Jul 19, 2024

good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants