Code dedup in execution_trace_utils LiteralToValue #17170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedwm
approved these changes
Sep 13, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 674470428
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR openxla/xla#17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50deff921dd98b530df1994b3317073ac528f7 by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17170 from apivovarov:opt_execution_trace_utils 2b50deff921dd98b530df1994b3317073ac528f7 PiperOrigin-RevId: 674470428
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 674470428
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 674470428
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 674470428
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 674470428
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 675320810
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 16, 2024
Imported from GitHub PR openxla/xla#17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50deff921dd98b530df1994b3317073ac528f7 by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17170 from apivovarov:opt_execution_trace_utils 2b50deff921dd98b530df1994b3317073ac528f7 PiperOrigin-RevId: 675320810
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 675320810
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 17, 2024
Imported from GitHub PR openxla/xla#17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50deff921dd98b530df1994b3317073ac528f7 by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17170 from apivovarov:opt_execution_trace_utils 2b50deff921dd98b530df1994b3317073ac528f7 PiperOrigin-RevId: 675320810
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Imported from GitHub PR #17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50def by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17170 from apivovarov:opt_execution_trace_utils 2b50def PiperOrigin-RevId: 675320810
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 17, 2024
Imported from GitHub PR openxla/xla#17170 Code dedup in execution_trace_utils LiteralToValue ### Issue descr: To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement. Copybara import of the project: -- 2b50deff921dd98b530df1994b3317073ac528f7 by Alexander Pivovarov <pivovaa@amazon.com>: Code dedup in execution_trace_utils LiteralToValue Merging this change closes #17170 PiperOrigin-RevId: 675361983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code dedup in execution_trace_utils LiteralToValue
Issue descr:
To avoid having to modify this every time a new FP8 type is added, remove all these FP8 cases and check if IsF8Type(literal.shape().element_type() before the switch statement.