Use switch case without default in LiteralToValue #17279
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommendation:
Missing switch cases are a compiler error, so having a switch without a default case is preferable when possible
Change:
in
xla/mlir/tools/mlir_replay/public/execution_trace_utils.cc :: LiteralToValue(Literal) -> InterpreterValue
This PR removes IsTuple(), IsToken(), IsArray(), IsF8Type() and refactors the code to use single switch case block.