Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for gevent crash on Windows. #121

Merged
merged 3 commits into from Sep 17, 2014
Merged

Fix for gevent crash on Windows. #121

merged 3 commits into from Sep 17, 2014

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2014

import socket is needed for windows.

olorin added a commit that referenced this pull request Sep 17, 2014
Fix for gevent crash on Windows.
@olorin olorin merged commit 64e1f8b into openyou:master Sep 17, 2014
@warrenarea
Copy link

i was looking over gevent code and they import the socket
to trigger the WSAstartup call, (to prevent it from crashing), and
then delete it right after. would probably be a good idea in
practice not to have the sockets import lingering around.

import sys
if sys.platform == 'win32':
import socket # trigger WSAStartup call
del socket
del sys

@warrenarea
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants