Skip to content

Commit

Permalink
ZTS: Add missing quotes
Browse files Browse the repository at this point in the history
`default_setup` takes a disk list as the first argument and has
optional additional arguments that control secondary functionality.
A couple of test setups mistakenly call `default_setup $DISKS`.

Add quotes so the second and subsequent disks are correctly included
in the pool as vdevs rather than triggering unwanted behavior from
`default_setup`.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #10097
  • Loading branch information
behlendorf committed Mar 4, 2020
1 parent 4b06d05 commit fa23c5b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ else
log_note "This machine is running ZFS Filesystem version $ZFS_VERSION"
fi

default_setup $DISKS
default_setup "$DISKS"
2 changes: 1 addition & 1 deletion tests/zfs-tests/tests/functional/write_dirs/setup.ksh
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@

verify_runnable "global"

default_setup $DISKS
default_setup "$DISKS"

0 comments on commit fa23c5b

Please sign in to comment.