-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a clean rewrite of arc_summary.py in Python 3 #6873
Comments
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 22, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Developed for Python 3.5. Add new options: -g/--graph - Display crude graphic respresentation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print one single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Now prints information if sections such as L2ARC and VDEV are skipped instead of failing silently. Note arc_summary3.py is not included in Makefile.am at this point. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 22, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Developed for Python 3.5. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page is depreciated. Note arc_summary3.py is not included in Makefile.am at this point. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 22, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Note arc_summary3.py is not included in Makefile.am at this point. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
13 tasks
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 22, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Note arc_summary3.py is not included in Makefile.am at this point. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 22, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Note arc_summary3.py is not included in Makefile.am at this point. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Nov 28, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note arc_summary3.py is not included in Makefile.am at this point. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 4, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note arc_summary3.py is not included in Makefile.am at this point. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 5, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note arc_summary3.py is not included in Makefile.am at this point. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 6, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note the associated test file currently opts out of flake8 testing. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 7, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note the associated test file currently opts out of flake8 testing. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 8, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note the associated test file currently opts out of flake8 testing. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 12, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note the associated test file currently opts out of flake8 testing. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
akatrevorjay
added a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 14, 2017
* scotws-python3: Add Python 3 rewrite of arc_summary.py (openzfs#6873)
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 15, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note the associated test file currently opts out of flake8 testing. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Dec 16, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note the associated test file currently opts out of flake8 testing. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
akatrevorjay
pushed a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 16, 2017
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873). Add test_arc_summary3.py as (incomplete) unittest test suite. Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Adds first (trivial) tests. Note the associated test file currently opts out of flake8 testing. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
akatrevorjay
added a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 16, 2017
…h-kingdom * 'patch-kingdom' of github.com:akatrevorjay/zfs: Add Python 3 rewrite of arc_summary.py (openzfs#6873) Add dbuf hash and dbuf cache kstats Use Multi-buffer sha256 support from SPL mutex tracking: disable tracking of ARC and dbuf hashmap locks Fix distribution detection so that Ubuntu does not identify as Debian Support ashift=13 to support 8KB SSD page sizes
akatrevorjay
added a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 16, 2017
* akatrevorjay/patch-kingdom: (27 commits) merge Add Python 3 rewrite of arc_summary.py (openzfs#6873) Use Multi-buffer sha256 support from SPL Add dbuf hash and dbuf cache kstats Fix distribution detection so that Ubuntu does not identify as Debian Support ashift=13 to support 8KB SSD page sizes mutex tracking: disable tracking of ARC and dbuf hashmap locks Review feedback 2 Remove vdev_raidz_map_alloc() Review feedback Update and add additional TRIM test cases Want manual trim feature to skip never-allocated space Deadlockiness in autotrim due to recent changes. Matt Ahrens' review comments, round 5. Deadlockiness associated with doing postponing trimming on a metaslab wanting to condense. Matt Ahren's review comments round 4: Tim Chase's review comments, round 2. Matt Ahrens' review comments, round 3. Matt Ahrens' review comments. Fix abd_alloc_sametype() panic ...
akatrevorjay
added a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 16, 2017
* 'upstream' of github.com:akatrevorjay/zfs: (27 commits) merge Add Python 3 rewrite of arc_summary.py (openzfs#6873) Use Multi-buffer sha256 support from SPL Add dbuf hash and dbuf cache kstats Fix distribution detection so that Ubuntu does not identify as Debian Support ashift=13 to support 8KB SSD page sizes mutex tracking: disable tracking of ARC and dbuf hashmap locks Review feedback 2 Remove vdev_raidz_map_alloc() Review feedback Update and add additional TRIM test cases Want manual trim feature to skip never-allocated space Deadlockiness in autotrim due to recent changes. Matt Ahrens' review comments, round 5. Deadlockiness associated with doing postponing trimming on a metaslab wanting to condense. Matt Ahren's review comments round 4: Tim Chase's review comments, round 2. Matt Ahrens' review comments, round 3. Matt Ahrens' review comments. Fix abd_alloc_sametype() panic ...
akatrevorjay
added a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 16, 2017
* scotws-python3: Add Python 3 rewrite of arc_summary.py (openzfs#6873)
akatrevorjay
added a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 16, 2017
* akatrevorjay/patch-kingdom: (27 commits) merge Add Python 3 rewrite of arc_summary.py (openzfs#6873) Use Multi-buffer sha256 support from SPL Add dbuf hash and dbuf cache kstats Fix distribution detection so that Ubuntu does not identify as Debian Support ashift=13 to support 8KB SSD page sizes mutex tracking: disable tracking of ARC and dbuf hashmap locks Review feedback 2 Remove vdev_raidz_map_alloc() Review feedback Update and add additional TRIM test cases Want manual trim feature to skip never-allocated space Deadlockiness in autotrim due to recent changes. Matt Ahrens' review comments, round 5. Deadlockiness associated with doing postponing trimming on a metaslab wanting to condense. Matt Ahren's review comments round 4: Tim Chase's review comments, round 2. Matt Ahrens' review comments, round 3. Matt Ahrens' review comments. Fix abd_alloc_sametype() panic ...
akatrevorjay
added a commit
to akatrevorjay/zfs
that referenced
this issue
Dec 16, 2017
* 'upstream' of github.com:akatrevorjay/zfs: (27 commits) merge Add Python 3 rewrite of arc_summary.py (openzfs#6873) Use Multi-buffer sha256 support from SPL Add dbuf hash and dbuf cache kstats Fix distribution detection so that Ubuntu does not identify as Debian Support ashift=13 to support 8KB SSD page sizes mutex tracking: disable tracking of ARC and dbuf hashmap locks Review feedback 2 Remove vdev_raidz_map_alloc() Review feedback Update and add additional TRIM test cases Want manual trim feature to skip never-allocated space Deadlockiness in autotrim due to recent changes. Matt Ahrens' review comments, round 5. Deadlockiness associated with doing postponing trimming on a metaslab wanting to condense. Matt Ahren's review comments round 4: Tim Chase's review comments, round 2. Matt Ahrens' review comments, round 3. Matt Ahrens' review comments. Fix abd_alloc_sametype() panic ...
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 13, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 17, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 20, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 20, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 24, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 27, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 28, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 28, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 28, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 28, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 31, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Jan 31, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 1, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 2, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 4, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 5, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 6, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 8, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 8, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 25, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 27, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 27, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
scotws
added a commit
to scotws/zfs
that referenced
this issue
Feb 27, 2018
Add new script arc_summary3.py as a complete rewrite of the arc_summary.py tool (see issue openzfs#6873) Add new options: -g/--graph - Display crude graphic representation of ARC status and quit -r/--raw - Print all available information as minimally formatted list (for grep) -s/--section - Print a single section. This replaces -p/--page, which is kept for backwards use but marked as depreciated Add new sections with information on ZIL and SPL. Notify user if sections L2ARC and VDEV are skipped instead of failing silently. Add warning that -p/--page option is depreciated. Developed for Python 3.5. Signed-off-by: Scot W. Stevenson <scot.stevenson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background. arc_summary.py is a Python script to report basic information on the ZFS cache system. The original version was written 2008 by Ben Rockwood in Perl for Solaris machines (see http://cuddletech.com/?p=454 for his original blog posting). It has since been ported to Python and Linux (see https://github.com/zfsonlinux/zfs/blob/master/cmd/arc_summary/arc_summary.py)
The Problem. The current version of arc_summary.py must work with various distributions, some of which use ancient versions of Python (e.g. CentOS 6, which seems to be using Python 2.6.6, now seven years old; see https://danieleriksson.net/2017/02/08/how-to-install-latest-python-on-centos/ for details). This means it is stuck with (for example) the
getopt
library instead ofargparse
, and primitivesubprocess
code. At the same time, it must work with Python 3. Also, despite various rewrites by many people, it still betrays its Perl roots with downright un-Pythonic code, making it harder to understand, maintain and enhance. This will only get worse as Python 2 approaches EOL in now only slightly more than two years (see https://pythonclock.org/).Suggestion. To fix this, we could add a version of arc_summary.py rewritten, mostly from scratch, in pure Python 3, possibly with the name arc_summary3.py. It would be included in the same folder as the existing script, which would be kept and maintained for backward use. The hope is that more Pythonic code will make it easier for more people to add to and improve upon the new version.
Complications. Any rewrite of this scale would almost certainly introduce bugs. The ZoL test suites would have to be retooled to accept a Python 3 program even though it could only run on a subgroup of systems. It can be assumed that fewer people will show an interest in working on the older version of arc_summary.py if there is a newer version around, possibly orphaning the original, still important version.
Who would write this? I have spent the last couple of weeks with the current arc_summary.py version (see PRs) and also have written a (very experimental) partial port in Go (golang) at https://github.com/scotws/arc_summary_go. I could put together an initial version of arc_summary3.py as a code base; however I have no idea how to include this in the build and tests systems of ZoL. Also, I'm sure any Python code I write could be improved upon.
The text was updated successfully, but these errors were encountered: