Fix per-jail zfs.mount_snapshot setting #14509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 18, 2023
When jail.conf set the nopersist flag during startup, it was incorrectly destroying the per-jail ZFS settings. Sponsored-by: Modirum MDPay Sponsored-by: Klara, Inc. Signed-off-by: Allan Jude <allan@klarasystems.com>
allanjude
force-pushed
the
jail_inherit_fix
branch
from
1170471 to
de1856c
Compare
mmatuska
approved these changes
Feb 19, 2023
ghost
added
the
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 3, 2023
When jail.conf set the nopersist flag during startup, it was incorrectly destroying the per-jail ZFS settings. Reported-by: Martin Matuska <mm@FreeBSD.org> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Allan Jude <allan@klarasystems.com> Sponsored-by: Modirum MDPay Sponsored-by: Klara, Inc. Closes openzfs#14509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponsored-by: Modirum MDPay
Sponsored-by: Klara, Inc.
Motivation and Context
jsys = -1(no matching parameters) andjsys = JAIL_SYS_INHERITwere being treated the same when they should not have been.This meant that when jail.conf set the nopersist flag (for some reason as a second stop) during startup, it was incorrectly destroying the per-jail ZFS settings.
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.