Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tests, some variables missing PERF_ prefix #9877

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Performance tests, some variables missing PERF_ prefix #9877

merged 1 commit into from
Jan 24, 2020

Conversation

tonynguien
Copy link
Contributor

Motivation and Context

Performance test broken due to a minor bug

Description

Adding the expected PERF_ prefix to RANDSEED, COMPPERCENT, and COMPCHUNK

How Has This Been Tested?

Performance tests run successfully.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jan 23, 2020
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 23, 2020
@tonynguien
Copy link
Contributor Author

Please hold the merge. My latest run is hitting some failures.

@behlendorf behlendorf added Status: Work in Progress Not yet ready for general review and removed Status: Accepted Ready to integrate (reviewed, tested) labels Jan 23, 2020
@behlendorf
Copy link
Contributor

@tonynguien will do.

Signed-off-by: Tony Nguyen <tony.nguyen@delphix.com>
@tonynguien
Copy link
Contributor Author

@tonynguien will do.

Thanks @behlendorf. I missed the changes to mkfiles.fio. I've updated the PR and kicked off another performance run.

Will send another update once those tests complete.

@tonynguien
Copy link
Contributor Author

Performance tests completed successfully.

--- Configuration ---
Runfiles: runfiles/perf-regression.run
STF_TOOLS: /usr/share/zfs/test-runner
STF_SUITE: /usr/share/zfs/zfs-tests
STF_PATH: /var/tmp/constrained_path.Ssve
FILEDIR: /var/tmp
FILES: /var/tmp/file-vdev0 /var/tmp/file-vdev1 /var/tmp/file-vdev2
LOOPBACKS:
DISKS: sdb sdc sdd sde
NUM_DISKS: 4
FILESIZE: 4G
ITERATIONS: 1
TAGS: perf
STACK_TRACER: no
Keep pool(s): rpool
Missing util(s): arc_summary3 mmap_libaio pax quotaon umask uuidgen wait setenforce

/usr/share/zfs/test-runner/bin/test-runner.py -c "runfiles/perf-regression.run" -T "perf" -i "/usr/share/zfs/zfs-tests" -I "1"
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/setup (run as root) [00:00] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/sequential_writes (run as root) [03:55] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/sequential_reads (run as root) [10:29] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/sequential_reads_arc_cached (run as root) [03:03] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/sequential_reads_arc_cached_clone (run as root) [02:59] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/sequential_reads_dbuf_cached (run as root) [00:37] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/random_reads (run as root) [09:00] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/random_writes (run as root) [01:14] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/random_readwrite (run as root) [07:50] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/random_writes_zil (run as root) [04:52] [PASS]
Test: /usr/share/zfs/zfs-tests/tests/perf/regression/random_readwrite_fixed (run as root) [09:11] [PASS]

Results Summary
PASS 11

Running Time: 00:53:16
Percent passed: 100.0%
Log directory: /var/tmp/test_results/20200123T234028

No test results were found.
Log directory: /var/tmp/test_results/20200123T234028

@behlendorf
Copy link
Contributor

Great. Then I'll go ahead and merge this once the CI is done with it.

@tonynguien
Copy link
Contributor Author

Great. Then I'll go ahead and merge this once the CI is done with it.

Thanks @behlendorf!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Work in Progress Not yet ready for general review labels Jan 24, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #9877 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #9877    +/-   ##
========================================
+ Coverage      79%      79%   +<1%     
========================================
  Files         384      384            
  Lines      121644   121644            
========================================
+ Hits        96523    96541    +18     
+ Misses      25121    25103    -18
Flag Coverage Δ
#kernel 80% <ø> (ø) ⬆️
#user 67% <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5206b82...43145b3. Read the comment docs.

@behlendorf behlendorf merged commit 8e9e90b into openzfs:master Jan 24, 2020
@tonynguien tonynguien deleted the perf_test_fix branch January 24, 2020 14:45
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Adding the expected PERF_ prefix to RANDSEED, COMPPERCENT,
and COMPCHUNK.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Nguyen <tony.nguyen@delphix.com>
Closes openzfs#9877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants