-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance tests, some variables missing PERF_ prefix #9877
Conversation
Please hold the merge. My latest run is hitting some failures. |
@tonynguien will do. |
Signed-off-by: Tony Nguyen <tony.nguyen@delphix.com>
Thanks @behlendorf. I missed the changes to Will send another update once those tests complete. |
Performance tests completed successfully. --- Configuration --- /usr/share/zfs/test-runner/bin/test-runner.py -c "runfiles/perf-regression.run" -T "perf" -i "/usr/share/zfs/zfs-tests" -I "1" Results Summary Running Time: 00:53:16 No test results were found. |
Great. Then I'll go ahead and merge this once the CI is done with it. |
Thanks @behlendorf! |
Codecov Report
@@ Coverage Diff @@
## master #9877 +/- ##
========================================
+ Coverage 79% 79% +<1%
========================================
Files 384 384
Lines 121644 121644
========================================
+ Hits 96523 96541 +18
+ Misses 25121 25103 -18
Continue to review full report at Codecov.
|
Adding the expected PERF_ prefix to RANDSEED, COMPPERCENT, and COMPCHUNK. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Nguyen <tony.nguyen@delphix.com> Closes openzfs#9877
Motivation and Context
Performance test broken due to a minor bug
Description
Adding the expected
PERF_
prefix to RANDSEED, COMPPERCENT, and COMPCHUNKHow Has This Been Tested?
Performance tests run successfully.
Types of changes
Checklist:
Signed-off-by
.