-
-
Notifications
You must be signed in to change notification settings - Fork 19
Closed
Description
Since 3.3.0, the reencode
function (or more exactly the private _build_ffmpeg_args
function) is auto-magically adding the -threads
argument to the passed ffmpeg_args
:
python-scraperlib/src/zimscraperlib/video/encoding.py
Lines 22 to 26 in 453afc0
if threads: | |
if "-threads" in ffmpeg_args: | |
raise AttributeError("Cannot set the number of threads, already set") | |
else: | |
ffmpeg_args += ["-threads", str(threads)] |
This causes issues like openzim/kolibri#89 where since we are retrying to encode the video multiple times, the same dictionary is modified twice.
I think that reencode
function should not modify the passed dictionary but its own copy.
I add this to the 3.4.0
for now, but clearly deserve a 3.3.1
patch I think.
WDYT?
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working