Add access to base_href and url_rewriter in HTML tag rewriting #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 2221 2221
Branches 426 426
=========================================
Hits 2221 2221 ☔ View full report in Codecov by Sentry. |
rgaudin
approved these changes
Oct 25, 2024
benoit74
force-pushed
the
mindtouch_changes
branch
from
9f8bc1f to
ecdae6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mindtouch scraper, we need to enrich the possibilities of HTML tag rewriting rules, by having access to current base_href and url_rewriter.