Switches Elasticsearch to only write single-type indexes #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @openzipkin/elasticsearch |
codefromthecrypt
force-pushed
the
formalize-single-type-indexing
branch
from
4bcef54
to
3b9f8cb
Compare
Multi-type indexes are no longer supported starting with Elasticsearch 6. We added support for single-type writes in Zipkin 1.29 as an opt-in functionality via `ES_EXPERIMENTAL_SPAN2=true`. This makes single- type writes the only means to ingest spans, eventhough we still read both models. To turn off dual-reads, set `ES_LEGACY_READS_ENABLED=false` once your collectors have been updated to Zipkin 1.31 and old indexes are no longer valuable.
codefromthecrypt
force-pushed
the
formalize-single-type-indexing
branch
from
3b9f8cb
to
1bebd4a
Compare
|
here's the double-conversion which is easier to obviate when we know how storage happens by type #1700 |
codefromthecrypt
pushed a commit
that referenced
this pull request
Aug 23, 2017
* Switches Elasticsearch to only write single-type indexes (#1698) Multi-type indexes are no longer supported starting with Elasticsearch 6. We added support for single-type writes in Zipkin 1.29 as an opt-in functionality via `ES_EXPERIMENTAL_SPAN2=true`. This makes single- type writes the only means to ingest spans, eventhough we still read both models. To turn off dual-reads, set `ES_LEGACY_READS_ENABLED=false` once your collectors have been updated to Zipkin 1.31 and old indexes are no longer valuable. * Deprecates Collector.acceptSpans(List<byte[]> ..
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…1698) Multi-type indexes are no longer supported starting with Elasticsearch 6. We added support for single-type writes in Zipkin 1.29 as an opt-in functionality via `ES_EXPERIMENTAL_SPAN2=true`. This makes single- type writes the only means to ingest spans, eventhough we still read both models. To turn off dual-reads, set `ES_LEGACY_READS_ENABLED=false` once your collectors have been updated to Zipkin 1.31 and old indexes are no longer valuable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-type indexes are no longer supported starting with Elasticsearch
6. We added support for single-type writes in Zipkin 1.29 as an opt-in
functionality via
ES_EXPERIMENTAL_SPAN2=true. This makes single-type writes the only means to ingest spans, eventhough we still read
both models.
To turn off dual-reads, set
ES_LEGACY_READS_ENABLED=falseonce yourcollectors have been updated to Zipkin 1.31 and old indexes are no longer
valuable.