Add cassandra Docker config to main repo. #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @openzipkin/cassandra cassandra test image is being re-homed |
| @@ -25,6 +25,15 @@ for tag in ${TAGS[@]:1}; do | |||
| docker tag "openzipkin/zipkin-ui:${TAGS[0]}" "openzipkin/zipkin-ui:$tag" | |||
| done | |||
|
|
|||
| # We also build storage images to correspond with the server version to keep schemas up to date | |||
There was a problem hiding this comment.
we also need to build the one-off one: kafka
|
|
||
| WORKDIR /cassandra | ||
|
|
||
| ADD zipkin-storage/cassandra/src/main/resources/*.cql /zipkin-schemas/ |
There was a problem hiding this comment.
easier! soon ideally we can generate an elasticsearch one using the main class, also cc @basvanbeek
| ADD docker/storage/cassandra/run.sh /usr/local/bin/run.sh | ||
| CMD ["/usr/local/bin/run.sh"] | ||
|
|
||
| EXPOSE 9160 7000 7001 9042 7199 |
There was a problem hiding this comment.
sgtm though not sure how many of these we actually need cc @michaelsembwever ... fine for now.
| sed -i '/-XX:NumberOfGCLogFiles=10/c\#-XX:NumberOfGCLogFiles=10' /cassandra/conf/jvm.options | ||
| sed -i '/-XX:GCLogFileSize=10M/c\#-XX:GCLogFileSize=10M' /cassandra/conf/jvm.options | ||
|
|
||
| # TODO: Add native snappy lib. Native loader stacktraces in the cassandra log as a results, which is distracting. |
codefromthecrypt
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with just Cassandra for now as it's the most complicated build. Verified it works with ITCassandraStorage
Changes from
docker-zipkinRemoves custom config loader - it was for using a stripped down JRE without
java.beansbut our Java 8 image has had it since migrating from Azul to OpenJDK. And our Java 11 image has it too since spring, so no real worries of it going awayMerges in our custom configuration (enable user defined functions, docker IP) using sed, similar to how official cassandra docker image works.