Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication via Openshift to Argo Workflows #39

Closed
HumairAK opened this issue Nov 25, 2020 · 7 comments
Closed

Add authentication via Openshift to Argo Workflows #39

HumairAK opened this issue Nov 25, 2020 · 7 comments
Labels
authentication blocked lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@HumairAK
Copy link
Member

HumairAK commented Nov 25, 2020

Ideally via openshift

@tumido tumido self-assigned this Nov 30, 2020
@tumido
Copy link
Member

tumido commented Nov 30, 2020

We can do that just fine, once we have opendatahub-io/odh-manifests#208 merged and applied. Argo Workflows supports SSO since v2.9 however, current ODH features v2.7.After my update we'll have the latest, v2.12 available, hence we can do SSO. I'll take care of it.

@tumido
Copy link
Member

tumido commented Dec 8, 2020

POC with a standalone DEX https://github.com/tumido/odh-manifests/tree/argo-sso/argo

kustomize build argo/components/dex | oc apply -f -
kustomize build argo/overlays/aiops-prod-argo | oc apply -f -

@HumairAK HumairAK changed the title Explore auth options for argo workflows Add authentication via Openshift to Argo Workflows Dec 8, 2020
@sesheta
Copy link
Member

sesheta commented Oct 11, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2021
@tumido
Copy link
Member

tumido commented Nov 9, 2021

/unassign @tumido

@sesheta
Copy link
Member

sesheta commented Dec 9, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 9, 2021
@sesheta
Copy link
Member

sesheta commented Jan 8, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Jan 8, 2022

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication blocked lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants