Skip to content

Conversation

nijaba
Copy link
Contributor

@nijaba nijaba commented Aug 12, 2022

Karsten asked me to propose this post

@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for operate-first-cloud ready!

Name Link
🔨 Latest commit e20d555
🔍 Latest deploy log https://app.netlify.com/sites/operate-first-cloud/deploys/62fcacca1f9b7e0008828fa2
😎 Deploy Preview https://deploy-preview-182--operate-first-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2022
@sesheta
Copy link
Member

sesheta commented Aug 12, 2022

Hi @nijaba. Thanks for your PR.

I'm waiting for a operate-first member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@schwesig
Copy link
Contributor

@nijaba Thanks for the post. I am okay with the index file, but I guess the .ds files are MacOS-related files?
@durandom, can we ignore them/ get rid of them?

@nijaba
Copy link
Contributor Author

nijaba commented Aug 15, 2022

Sorry about the .DS_Store files, added them to .gitignore.

Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@durandom
Copy link
Member

/ok-to-test

@durandom
Copy link
Member

@nijaba we can merge #183 , which fixes the colon problems and has a preview, or you can cherry-pick 3a35b51

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@nijaba
Copy link
Contributor Author

nijaba commented Aug 17, 2022

@nijaba we can merge #183 , which fixes the colon problems and has a preview, or you can cherry-pick 3a35b51

Thanks for the fixes. I cherry-picked them.

@durandom
Copy link
Member

/lgtm
/approve

@durandom
Copy link
Member

/ok-to-test

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2022
@sesheta
Copy link
Member

sesheta commented Aug 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: durandom, schwesig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit abc0641 into operate-first:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants