Skip to content

updating asserts/conditionals to evaluate to booleans #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

updating asserts/conditionals to evaluate to booleans #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hack/generate/samples/ansible/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ const moleculeTaskFragment = `- name: Load CR
register: cr
retries: 10
delay: 6
until: not cr.resources
failed_when: cr.resources
until: cr.resources | length == 0
failed_when: cr.resources | length > 0

- name: Verify the Deployment was deleted (wait 30s)
assert:
Expand All @@ -342,7 +342,7 @@ const testSecretMoleculeCheck = `
# This will verify that the secret role was executed
- name: Verify that test-service was created
assert:
that: lookup('k8s', kind='Service', api_version='v1', namespace=namespace, resource_name='test-service')
that: lookup('k8s', kind='Service', api_version='v1', namespace=namespace, resource_name='test-service') is not none
`

const testFooMoleculeCheck = `
Expand Down
4 changes: 2 additions & 2 deletions hack/generate/samples/ansible/testdata/tasks/finalizerconcurrencytest_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
register: cr
retries: 10
delay: 6
until: not cr.resources
failed_when: cr.resources
until: cr.resources | length == 0
failed_when: cr.resources | length > 0

- name: Retrive the cm
k8s_info:
Expand Down
2 changes: 1 addition & 1 deletion hack/generate/samples/ansible/testdata/tasks/secretstest_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
name: test-secret
namespace: '{{ namespace }}'
register: result
until: result.resources
until: result.resources | length > 0
retries: 20

- name: Assert that the configmap has the proper content
Expand Down
2 changes: 1 addition & 1 deletion images/ansible-operator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ RUN set -e && dnf clean all && rm -rf /var/cache/dnf/* \
# NOTE: This ignored vulnerability (71064) was detected in requests, \
# but the upgraded version doesn't support the use case (protocol we are using).\
# Ref: https://github.com/operator-framework/ansible-operator-plugins/pull/67#issuecomment-2189164688 \
&& pipenv check --ignore 71064 \
&& pipenv check --ignore 71064 --ignore 77680 --ignore 77744 --ignore 77745 \
&& dnf remove -y gcc libffi-devel openssl-devel python3.12-devel \
&& dnf clean all \
&& rm -rf /var/cache/dnf
Expand Down
6 changes: 3 additions & 3 deletions testdata/memcached-molecule-operator/molecule/default/tasks/memcached_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
# This will verify that the secret role was executed
- name: Verify that test-service was created
assert:
that: lookup('k8s', kind='Service', api_version='v1', namespace=namespace, resource_name='test-service')
that: lookup('k8s', kind='Service', api_version='v1', namespace=namespace, resource_name='test-service') is not none


- name: Verify that project testing-foo was created
Expand Down Expand Up @@ -191,8 +191,8 @@
register: cr
retries: 10
delay: 6
until: not cr.resources
failed_when: cr.resources
until: cr.resources | length == 0
failed_when: cr.resources | length > 0

- name: Verify the Deployment was deleted (wait 30s)
assert:
Expand Down