Skip to content

Conversation

chiragkyal
Copy link
Contributor

@chiragkyal chiragkyal commented Sep 16, 2025

Description of the change:

This PR removes the dependency on the archived ansible-runner-http Python package and replaces it with a local implementation to ensure continued functionality and eliminate external dependency risks.

Changes made:

  • Created local Python module (images/ansible-operator/ansible_runner_http/):

  • Updated Python dependencies:

    • Removed: ansible-runner-http = "~=1.0.0" from Pipfile
    • Added: requests-unixsocket = "==0.4.1"
    • Updated: Pipfile.lock with new dependency versions
  • Updated Dockerfile to copy and install local module during build

Motivation for the change:

The ansible-runner-http Python package was archived on May 23, 2024 and is no longer maintained.
This creates several risks:

  • Security vulnerabilities may not be patched.
  • Compatibility issues with future Python/dependency updates

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@chiragkyal chiragkyal force-pushed the remove-ansible-runner-http branch from a94f044 to 0945665 Compare September 16, 2025 18:17
@chiragkyal
Copy link
Contributor Author

In https://github.com/operator-framework/ansible-operator-plugins/actions/runs/17775712081/job/50522748371?pr=172 job run, we can see that the Ansible events are correctly streaming from Ansible Runner to the Operator end. Looks like the approach is working.

@acornett21 if you are also satisfied I will revert the debug commit: ba0b046

@chiragkyal
Copy link
Contributor Author

/cc @mytreya-rh

Copy link

openshift-ci bot commented Sep 16, 2025

@chiragkyal: GitHub didn't allow me to request PR reviews from the following users: mytreya-rh.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mytreya-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chiragkyal chiragkyal changed the title wip: Install ansible-runner-http as local python package Install ansible-runner-http as local python package Sep 16, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@acornett21
Copy link
Contributor

You need to update the .goreleaser to include the new files as extra_files to get that to build/pass.

@chiragkyal chiragkyal force-pushed the remove-ansible-runner-http branch from 2f3f679 to bf5aaae Compare September 16, 2025 20:28
@chiragkyal
Copy link
Contributor Author

@acornett21 PTAL at the latest changes, and let me know if it looks good. I can drop the debug log commit if rest of the things are in shape.

@acornett21
Copy link
Contributor

@chiragkyal Drop the debug messages in tests and this should be good to go.

Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal chiragkyal force-pushed the remove-ansible-runner-http branch from bf5aaae to 0efc8cb Compare September 26, 2025 17:24
@chiragkyal
Copy link
Contributor Author

@chiragkyal Drop the debug messages in tests and this should be good to go.

@acornett21 Done. Thanks for the review.

@acornett21 acornett21 merged commit e4b92e0 into operator-framework:main Sep 26, 2025
9 checks passed
@chiragkyal chiragkyal deleted the remove-ansible-runner-http branch September 27, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible-operator-plugins relying on abandoned python packages
2 participants