-
Notifications
You must be signed in to change notification settings - Fork 29
Install ansible-runner-http as local python package #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install ansible-runner-http as local python package #172
Conversation
a94f044
to
0945665
Compare
In https://github.com/operator-framework/ansible-operator-plugins/actions/runs/17775712081/job/50522748371?pr=172 job run, we can see that the Ansible events are correctly streaming from Ansible Runner to the Operator end. Looks like the approach is working. @acornett21 if you are also satisfied I will revert the debug commit: ba0b046 |
/cc @mytreya-rh |
@chiragkyal: GitHub didn't allow me to request PR reviews from the following users: mytreya-rh. Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
You need to update the |
2f3f679
to
bf5aaae
Compare
@acornett21 PTAL at the latest changes, and let me know if it looks good. I can drop the debug log commit if rest of the things are in shape. |
@chiragkyal Drop the debug messages in tests and this should be good to go. |
Signed-off-by: chiragkyal <ckyal@redhat.com>
bf5aaae
to
0efc8cb
Compare
@acornett21 Done. Thanks for the review. |
Description of the change:
This PR removes the dependency on the archived ansible-runner-http Python package and replaces it with a local implementation to ensure continued functionality and eliminate external dependency risks.
Changes made:
Created local Python module (
images/ansible-operator/ansible_runner_http/
):Updated Python dependencies:
ansible-runner-http = "~=1.0.0"
from Pipfilerequests-unixsocket = "==0.4.1"
Updated Dockerfile to copy and install local module during build
Motivation for the change:
The
ansible-runner-http
Python package was archived on May 23, 2024 and is no longer maintained.This creates several risks:
requests
dependency #127