Add conditions array to OperatorCondition's spec #119
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
The proposal: https://hackmd.io/9wG20hu5TU-y1HrkhvcsZQ?view FYI |
The conditions array in the spec is now available for operator to create/update as the operator progresses through installation process. As the spec is updated, the object generation will be incremented and it can be used for tracking object changes. Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
opcon-crd
branch
3 times, most recently
from
0b69bb6 to
92efc91
Compare
There was a problem hiding this comment.
Great turn around time on this @dinhxuanvu, left some nits.
dinhxuanvu
force-pushed
the
opcon-crd
branch
2 times, most recently
from
32d8563 to
cc02ecb
Compare
Signed-off-by: Vu Dinh <vudinh@outlook.com>
|
/lgtm |
|
Out of curiosity: why v2 and not v2beta1? Are we confident no significant changes will be needed soon? I feel that it’s a bit hasty to just throw a new stable version out, especially given how short the lifetime of v1 was. |
Spoke with Eric about this offline, posting here for visibility. We could have simply added the new fields to v1 but OLM would be unable to identify users that are still writing to the broken v1 API. Additionally, there were concerns that users would rely on a stable (v1) version over a beta/alpha version. |
The conditions array in the spec is now available for operator to
create/update as the operator progresses through installation
process. As the spec is updated, the object generation will be
incremented and it can be used for tracking object changes.
Signed-off-by: Vu Dinh vudinh@outlook.com