Refactor validate CRD to fix conversion error #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
exdx
approved these changes
Jan 17, 2020
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
dinhxuanvu
force-pushed
the
fix-validate-crd
branch
from
b99702e to
5a81c8f
Compare
1. Fix conversion error due to incompatible type 1. Refactor validate CRD code to reduce duplication 2. Support v1.CRD type Signed-off-by: Vu Dinh <vdinh@redhat.com>
dinhxuanvu
force-pushed
the
fix-validate-crd
branch
from
5a81c8f to
a7119ae
Compare
jpeeler
approved these changes
Jan 20, 2020
openshift-ci-robot
added
size/L
Signed-off-by: Vu Dinh <vdinh@redhat.com>
dinhxuanvu
force-pushed
the
fix-validate-crd
branch
from
3973850 to
fab55ed
Compare
jpeeler
reviewed
Jan 20, 2020
|
|
||
| results := []errors.ManifestResult{} | ||
| switch tt.version { | ||
| case "v1": |
There was a problem hiding this comment.
I'd make this default rather than the beta version. But really only if you want to.
jpeeler
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vu Dinh vdinh@redhat.com