community-validator: improve msgs raised #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
reviewed
May 27, 2021
njhale
reviewed
May 27, 2021
pkg/validation/internal/community.go
Outdated
| if verParsed.GE(semVerOCPV1beta1Unsupported) { | ||
| checks.errs = append(checks.errs, fmt.Errorf("this bundle is %s. Migrate the API(s) "+ | ||
| "for %s or use the OCP labels for compatible version(s). (e.g. LABEL %s='=v4.8')", | ||
| checks.errs = append(checks.errs, fmt.Errorf("this bundle is %s. Migrate the API(s) for "+ |
There was a problem hiding this comment.
nit: I know there's precedent in this file, but I would like to stop using string concatenation as a way of making literals more readable for engineers -- almost all text editors have line-wrapping.
njhale
reviewed
May 27, 2021
|
/lgtm |
camilamacedo86
commented
May 27, 2021
| func checkOCPLabelsWithHasDeprecatedAPIs(checks CommunityOperatorChecks, deprecatedAPImsg string) CommunityOperatorChecks { | ||
| // Note that we cannot make mandatory because the package format still valid | ||
| if len(checks.indexImagePath) == 0 && len(checks.indexImage) == 0 { | ||
| if len(checks.indexImagePath) == 0 { |
There was a problem hiding this comment.
cleanup - not used.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.