Skip to content

feat: update the channel namming conv #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

feat: update the channel namming conv #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/validation/internal/operatorhub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ func validateBundleOperatorHub(bundle *manifests.Bundle, k8sVersion string) erro
// authors knows if their operator bundles are or not respecting the Naming Convention Rules.
// However, the operator authors still able to choose the names as please them.
func validateHubChannels(channels []string) error {
const preview = "preview"
const candidate = "candidate"
const stable = "stable"
const fast = "fast"

var channelsNotFollowingConventional []string
for _, channel := range channels {
if !strings.HasPrefix(channel, preview) &&
if !strings.HasPrefix(channel, candidate) &&
!strings.HasPrefix(channel, stable) &&
!strings.HasPrefix(channel, fast) {
channelsNotFollowingConventional = append(channelsNotFollowingConventional, channel)
Expand Down
2 changes: 1 addition & 1 deletion pkg/validation/internal/operatorhub_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ func TestValidateHubChannels(t *testing.T) {
{
name: "should not return warning when the channel names following the convention",
args: args{
channels: []string{"fast", "preview"},
channels: []string{"fast", "candidate"},
},
wantWarn: false,
},
Expand Down