add storage spec to scorecard config #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e245efd)
|
/approve |
fabianvf
force-pushed
the
scorecard-storage
branch
from
b636b2c to
a5675f8
Compare
2 tasks
varshaprasad96
approved these changes
Jul 1, 2021
estroz
requested changes
Jul 1, 2021
| // Labels further describe the test and enable selection. | ||
| Labels map[string]string `json:"labels,omitempty" yaml:"labels,omitempty"` | ||
| Labels map[string]string `json:"labels,omitempty" yaml:"labels,omitempty"` | ||
| Storage Storage `json:"storage,omitempty" yaml:"storage,omitempty"` |
There was a problem hiding this comment.
Fields and type defs need descriptive godocs, since they are the only docs source for this repo right now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, jmrodri, theishshah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e245efd)
Required for operator-framework/operator-sdk#5028