Add conditions to catalog source #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
approved these changes
Jul 22, 2021
| // +patchStrategy=merge | ||
| // +listType=map | ||
| // +listMapKey=type | ||
| Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"` |
There was a problem hiding this comment.
nit: CRs don't get encoded as protobuf so that tag could be omitted.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jchunkins, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
It looks like tide's blocking on an optional github action. I opened openshift/release#20513 to update the tide configuration to alleviate this problem. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional array of
k8s.io/apimachinery/pkg/apis/meta/v1.Conditionwhose name isconditionsto the CatalogSource status. This is being done to allow for condition support for use with theautomatic-catalog-switching-annotationsenhancement proposal PR (which has yet to be merged).Note that the initial use of the
conditionsfield will be the catalog template resolution logic, and will be used to indicate the status of catalog template resolution. In the future the OLM catalog operator could migrate to usingconditionsinstead of the existingMessageandReasonfields but that is out of scope for the enhancement proposal.