Skip to content

Conversation

exdx
Copy link
Contributor

@exdx exdx commented Aug 11, 2021

Signed-off-by: Daniel Sover dsover@redhat.com

Signed-off-by: Daniel Sover <dsover@redhat.com>
@openshift-ci openshift-ci bot requested review from estroz and gallettilance August 11, 2021 15:17
exdx added 2 commits August 11, 2021 11:21
Signed-off-by: Daniel Sover <dsover@redhat.com>
Signed-off-by: Daniel Sover <dsover@redhat.com>
k8s.io/apiextensions-apiserver v0.22.0
k8s.io/apimachinery v0.22.0
k8s.io/client-go v0.22.0
sigs.k8s.io/controller-runtime v0.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also pin this to kubernetes-sigs/controller-runtime@b5eeb71, do so in a follow-up, or wait until 0.10.0 is released.

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021
@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@openshift-ci openshift-ci bot merged commit 74543ec into operator-framework:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants