GitHub action #19
Merged
GitHub action #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
Closed
Bowenislandsong
force-pushed
the
githubAction
branch
3 times, most recently
from
b542674 to
3055029
Compare
awgreene
reviewed
Feb 28, 2020
awgreene
reviewed
Feb 28, 2020
awgreene
reviewed
Feb 28, 2020
|
/lgtm I agree with @awgreene that the extra newlines aren't helping readability for me. Are there any sets of published YAML style rules with significant adoption? |
benluddy
approved these changes
Feb 28, 2020
Bowenislandsong
force-pushed
the
githubAction
branch
from
9e0e166 to
a0f39dc
Compare
I mostly try to keep the default style that github provides. The main thing was to keep each test separate, but since you all don't like it,,, I changed it. |
This commit enables Github Action. The uses of external images need sha based tag whereas GitHub action repos can use normal version tag.
Bowenislandsong
force-pushed
the
githubAction
branch
from
a0f39dc to
5ab1ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables Github Action. The uses of external images need sha based tag whereas GitHub action repos can use normal version tag.