Skip to content

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Nov 24, 2021

Description
Remove community validator. Its checks were moved to the external validator.

Motivation

We reach the consensus that this check is more vendor-like and specific and should not be shipped with operator-framework/api.

PS.: Let's merge this one by January 15, 2022

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
To complete the pull request process, please assign benluddy after the PR has been reviewed.
You can assign the PR to them by writing /assign @benluddy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Nov 24, 2021

I think we could merge this one by January 15, 2022
Adding
/hold
For we keep it up there.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@camilamacedo86 camilamacedo86 changed the title feat: remove community validator [do not merge before SDK 1.16 release] feat: remove community validator Nov 26, 2021
@camilamacedo86 camilamacedo86 changed the title [do not merge before SDK 1.16 release] feat: remove community validator [do not merge before SDK 1.17 rolls out] feat: remove community validator Nov 30, 2021
@camilamacedo86
Copy link
Contributor Author

Closing in favor to track the need via issue: operator-framework/operator-sdk#5422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant