Skip to content

chore(deps): Bump to kube 1.17 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2020
Merged

chore(deps): Bump to kube 1.17 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ require (
github.com/sirupsen/logrus v1.4.2
github.com/spf13/cobra v0.0.5
github.com/stretchr/testify v1.4.0
k8s.io/api v0.16.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use replace to pin the version? also, since we are following origin, should we use exactly the version they are using? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bowenislandsong thanks for reviewing the PR!
I see that origin is using 1.17.1, thanks for pointing that out. But could you help me understand why we'd wanna keep pace with origin? I don't see any dependency between api and origin.
Also, I don't get the need to use replace in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligning with origin will help when we need to pull api in olm, which also depends on origin for ClusterOperator apis.

(that said I think this patch version will be fine - I'm not sure that it's a big deal to differ in patch versions as long as we're prepared to resolve any inconsistencies if we hit them)

Copy link
Contributor Author

@anik120 anik120 Mar 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ecordell thanks for clarifying that. Is that a lgtm or a let's change the patch version anyway though? 😄 I don't mind changing it if we anticipate that we'll have to resolve inconsistencies.

k8s.io/apiextensions-apiserver v0.16.7
k8s.io/apimachinery v0.16.7
k8s.io/client-go v0.16.7
k8s.io/api v0.17.3
k8s.io/apiextensions-apiserver v0.17.3
k8s.io/apimachinery v0.17.3
k8s.io/client-go v0.17.3
)
98 changes: 98 additions & 0 deletions go.sum
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 0 additions & 25 deletions vendor/github.com/globalsign/mgo/LICENSE
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions vendor/github.com/globalsign/mgo/bson/LICENSE
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions vendor/github.com/globalsign/mgo/bson/README.md
View file
Open in desktop

This file was deleted.

Loading