Skip to content

Conversation

njhale
Copy link
Member

@njhale njhale commented Apr 1, 2020

Add types and deepcopy for the Operator API.

TODO:

  • add operator types
  • add codegen make rule
  • generate deepcopy

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2020
njhale added 5 commits April 1, 2020 13:24
Add the v2alpha1 group version and the initial Operator type definition.
In this form, the Operator type will support aggregating resource status
conditions to enable operator component discoverability.
Prevents fields of type *json.RawMessage from causing controller-gen to
output bad deepcopy types by switching to json.RawMessage. The
underlying type is []byte, so the fields remain semantically equivalent.
Add the generate and vendor rules to the Makefile. The generate rule
uses controller-gen to generate deepcopy types. The vendor rule updates
vendored dependencies and is a prereq of generate.
Update vendor directory to include the controller-tools dependency.
@njhale njhale changed the title WIP: feat(operators): add v2alpha1 operator types feat(operators): add v2alpha1 operator types Apr 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2020
@njhale
Copy link
Member Author

njhale commented Apr 1, 2020

/hold

Holding until I'm confident in this.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@njhale njhale force-pushed the op-disc branch 3 times, most recently from 07143f4 to b799e3a Compare April 8, 2020 20:04
njhale added 3 commits April 8, 2020 18:14
Add convenience getters that lazily unmarshal and memoize each of the latest CRDs.
Sync type definitions with the latest from OLM's repo. Update deepcopy
and manifests to match.
@njhale
Copy link
Member Author

njhale commented Apr 9, 2020

Superseded by #24

@njhale njhale closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants