Skip to content

Conversation

dinhxuanvu
Copy link
Member

Bundle validator is using registry.Bundle type that is meant for
registry-use only. As a result, changes in registry.Bundle will
break api validator. This bundle validator will be moved to
operator-registry and will be added back to api validator later.

Signed-off-by: Vu Dinh vdinh@redhat.com

Bundle validator is using registry.Bundle type that is meant for
registry-use only. As a result, changes in registry.Bundle will
break api validator. This bundle validator will be moved to
operator-registry and will be added back to api validator later.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu dinhxuanvu requested a review from exdx May 5, 2020 17:40
@exdx
Copy link
Contributor

exdx commented May 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 5, 2020
@dinhxuanvu
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@dinhxuanvu dinhxuanvu force-pushed the remove-bundle-validator branch from f5feddf to 9f686dc Compare May 5, 2020 18:18
@dinhxuanvu
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@exdx
Copy link
Contributor

exdx commented May 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@dinhxuanvu dinhxuanvu merged commit 363b6d8 into operator-framework:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants