Update webhook description #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Non-pointer fields are copied during an assignment, so it makes sense that there are no changes to deepcopy in this patch. |
njhale
reviewed
May 6, 2020
awgreene
force-pushed
the
update-webhook-description
branch
2 times, most recently
from
bf49804 to
3adba9d
Compare
awgreene
force-pushed
the
update-webhook-description
branch
from
3adba9d to
2be0117
Compare
Rather than providing users with an API to set the "Name" of the webhook, instead provide users with a method to set the generateName of the webhook.
awgreene
force-pushed
the
update-webhook-description
branch
from
2be0117 to
61c3659
Compare
This commit updates the CRD validation to only accept CSVs where the WebhookDefinition type is valid.
awgreene
force-pushed
the
update-webhook-description
branch
from
61c3659 to
19a9724
Compare
|
/approve This looks good to me! |
benluddy
reviewed
May 6, 2020
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace webhook description
Namefield withGenerateNameto match new semantics.for background, see operator-framework/operator-lifecycle-manager#1489 (comment)