validation: bundle CRDs are compared by definition key instead of name (#32) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
requested review from
dinhxuanvu,
gallettilance and
kevinrizza
kevinrizza
requested changes
Jun 2, 2020
| description: "registryv1 invalid bundle with duplicate CRD etcdclusters in bundle", | ||
| directory: "./testdata/invalid_bundle_3", | ||
| hasError: true, | ||
| errString: `duplicate CRD key "tests.test.example.com/v1alpha1" in bundle "test-operator.v0.0.1"`, |
| if err != (errors.Error{}) { | ||
| result.Add(err) | ||
| return result | ||
| ownedKeys := getOwnedCustomResourceDefintionKeys(csv) |
There was a problem hiding this comment.
I know it's outside the scope of this pr, but my nit for this would be that this function header has too many arguments if there's a pointer to the csv in the bundle anyway.
estroz
force-pushed
the
bugfix/bundle-validation
branch
from
060db51
to
53d53cd
Compare
|
/lgtm |
estroz
added a commit
to estroz/operator-registry
that referenced
this pull request
Jun 4, 2020
operator-framework/api#39. This update also removes the bou.ke/monkey dependency that has a very restrictive license.
5 tasks
ankitathomas
pushed a commit
to ankitathomas/operator-framework-olm
that referenced
this pull request
Apr 6, 2021
operator-framework/api#39. This update also removes the bou.ke/monkey dependency that has a very restrictive license. (upstream operator-registry commit: d73a908162177fafd045277cf4a90f5770a01de0)
openshift-merge-robot
pushed a commit
to openshift/operator-framework-olm
that referenced
this pull request
Jul 14, 2021
operator-framework/api#39. This update also removes the bou.ke/monkey dependency that has a very restrictive license. Upstream-repository: operator-registry Upstream-commit: d73a908162177fafd045277cf4a90f5770a01de0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32 was reverted at some point. This PR fixes the reversion, considering both v1 and v1beta1 CRDs.
/cc @dinhxuanvu @kevinrizza @gallettilance
/kind bug